linux-kernel - Re: [PATCH] Add BPF Kernel Function bpf_ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409261116.risxWG3M-lkp@intel.com>
Date: Thu, 26 Sep 2024 11:34:19 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Yan <eric.yan@...o.com>, ast@...nel.org, daniel@...earbox.net,
	andrii@...nel.org, martin.lau@...ux.dev, yonghong.song@...ux.dev,
	song@...nel.org, john.fastabend@...il.com, kpsingh@...nel.org,
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org, eric.yan@...o.com
Subject: Re: [PATCH] Add BPF Kernel Function bpf_ptrace_vprintk

Hi Eric,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]
[also build test WARNING on bpf/master linus/master next-20240925]
[cannot apply to v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Yan/Add-BPF-Kernel-Function-bpf_ptrace_vprintk/20240925-180530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20240925100254.436-1-eric.yan%40oppo.com
patch subject: [PATCH] Add BPF Kernel Function bpf_ptrace_vprintk
config: x86_64-buildonly-randconfig-003-20240926 (https://download.01.org/0day-ci/archive/20240926/202409261116.risxWG3M-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240926/202409261116.risxWG3M-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409261116.risxWG3M-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/bpf/helpers.c:2530: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * same as bpf_trace_vprintk, except for a trace_marker format requirement


vim +2530 kernel/bpf/helpers.c

  2528	
  2529	/**
> 2530	 * same as bpf_trace_vprintk, except for a trace_marker format requirement
  2531	 */
  2532	__bpf_kfunc int bpf_ptrace_vprintk(char *fmt, u32 fmt_size, const void *args, u32 args__sz)
  2533	{
  2534		struct bpf_bprintf_data data = {
  2535			.get_bin_args	= true,
  2536			.get_buf	= true,
  2537		};
  2538		int ret, num_args;
  2539	
  2540		if (args__sz & 7 || args__sz > MAX_BPRINTF_VARARGS * 8 || (args__sz && !args))
  2541			return -EINVAL;
  2542		num_args = args__sz / 8;
  2543	
  2544		ret = bpf_bprintf_prepare(fmt, fmt_size, args, num_args, &data);
  2545		if (ret < 0)
  2546			return ret;
  2547	
  2548		ret = bstr_printf(data.buf, MAX_BPRINTF_BUF, fmt, data.bin_args);
  2549	
  2550		tracing_mark_write(data.buf);
  2551	
  2552		bpf_bprintf_cleanup(&data);
  2553	
  2554		return ret;
  2555	}
  2556	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki