linux-kernel - Re: [PATCH -next] selftests/bpf: Use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4Bzaau0apKBM75BedphVUA9EHXfzC7wr4ugVZqohWZbLxRg@mail.gmail.com>
Date: Fri, 27 Sep 2024 13:58:55 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: andrii@...nel.org, eddyz87@...il.com, mykolal@...com, ast@...nel.org, 
	daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org, 
	yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org, 
	bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] selftests/bpf: Use ARRAY_SIZE for array length

On Fri, Sep 27, 2024 at 1:23 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
>
> ./tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c:98:34-35: WARNING: Use ARRAY_SIZE.
> ./tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c:93:29-30: WARNING: Use ARRAY_SIZE.
> ./tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c:101:34-35: WARNING: Use ARRAY_SIZE.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11167
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c b/tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c
> index a18d3680fb16..5e576c6cecca 100644
> --- a/tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c
> +++ b/tools/testing/selftests/bpf/prog_tests/core_reloc_raw.c
> @@ -7,7 +7,7 @@
>  #include <sys/syscall.h>
>  #include <bpf/libbpf.h>
>  #include <bpf/btf.h>
> -
> +#include "kselftest.h"

this doesn't compile, and I don't think you need this include

pw-bot: cr

>  #include "test_progs.h"
>  #include "test_btf.h"
>  #include "bpf/libbpf_internal.h"
> @@ -90,15 +90,15 @@ static void test_bad_local_id(void)
>         attr.prog_type = BPF_TRACE_RAW_TP;
>         attr.license = (__u64)"GPL";
>         attr.insns = (__u64)&insns;
> -       attr.insn_cnt = sizeof(insns) / sizeof(*insns);
> +       attr.insn_cnt = ARRAY_SIZE(insns);
>         attr.log_buf = (__u64)log;
>         attr.log_size = sizeof(log);
>         attr.log_level = log_level;
>         attr.func_info = (__u64)funcs;
> -       attr.func_info_cnt = sizeof(funcs) / sizeof(*funcs);
> +       attr.func_info_cnt = ARRAY_SIZE(funcs);
>         attr.func_info_rec_size = sizeof(*funcs);
>         attr.core_relos = (__u64)relos;
> -       attr.core_relo_cnt = sizeof(relos) / sizeof(*relos);
> +       attr.core_relo_cnt = ARRAY_SIZE(relos);
>         attr.core_relo_rec_size = sizeof(*relos);
>         prog_fd = sys_bpf_prog_load(&attr, sizeof(attr), 1);
>         saved_errno = errno;
> --
> 2.32.0.3.g01195cf9f
>