linux-kernel - Re: [PATCH 2/2] sis_main: Fix strbuf array overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db1de78a-8846-4fbf-9923-98614f60e73a@gmx.de>
Date: Sat, 28 Sep 2024 00:45:25 +0200
From: Helge Deller <deller@....de>
To: Andrey Shumilin <shum.sdl@...ct.ru>,
 Thomas Winischhofer <thomas@...ischhofer.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
 dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
 khoroshilov@...ras.ru, ykarpov@...ras.ru, vmerzlyakov@...ras.ru,
 vefanov@...ras.ru
Subject: Re: [PATCH 2/2] sis_main: Fix strbuf array overflow

On 9/27/24 21:34, Andrey Shumilin wrote:
> The values of the variables xres and yres are placed in strbuf.
> These variables are obtained from strbuf1.
> The strbuf1 array contains digit characters
> and a space if the array contains non-digit characters.
> Then, when executing sprintf(strbuf, "%ux%ux8", xres, yres);
> more than 16 bytes will be written to strbuf.
> It is suggested to increase the size of the strbuf array to 24.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Shumilin <shum.sdl@...ct.ru>

applied to fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/sis/sis_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 03c736f6f3d0..e907fde96ff4 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)
>   {
>   	unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;
>   	int i = 0;
> -	char strbuf[16], strbuf1[20];
> +	char strbuf[24], strbuf1[20];
>   	char *nameptr = name;
>
>   	/* We don't know the hardware specs yet and there is no ivideo */