linux-kernel - RE: [PATCH] x86/resctrl: Do not round up mba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083528F8C3BB96A5D46020DFC6B2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Fri, 27 Sep 2024 23:03:38 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Chatre, Reinette" <reinette.chatre@...el.com>, "Yu, Fenghua"
	<fenghua.yu@...el.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@...el.com>, Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>, "Drew
 Fustini" <dfustini@...libre.com>, Dave Martin <Dave.Martin@....com>, Borislav
 Petkov <bp@...en8.de>, Martin Kletzander <nert.pinx@...il.com>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: RE: [PATCH] x86/resctrl: Do not round up mba_MBps values in schemata
 file

> A fix for this issue is already being discussed. Please see latest fix
> at [1] that additionally addresses the issue if a user attempts to 
> write a value larger than 4294967295. Could you please check if that
> fix works for you?

That one looks more complete. My patch only covered the case for overflow
during roundup. That one uses kstrtou32() instead of kstrtoul() so will also
catch the case where a user enters a value bigger that U32_MAX.

-Tony