[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e9483a19f916982ba6996b81c2f1254da3801f3.camel@codeconstruct.com.au>
Date: Fri, 27 Sep 2024 15:13:26 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, patrick@...cx.xyz, Rob
Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/5] ARM: dts: aspeed: yosemite4: remove led gpio
pca9552 on fan boards
On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
>
> Remove led gpio contorller: pca9552 on fan boards since there is
> no binding document for pca9552 currently.
That's not true, there is, just it's not converted to dt-schema:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-pca955x.txt?h=v6.11
So the nodes can stay, though they probably generate warnings. The
right way to fix this is to convert the binding document.
Andrew
>
> Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> ---
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 04f6378c2b5f..430c28bdd314 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -525,15 +525,6 @@ eeprom@52 {
> compatible = "atmel,24c128";
> reg = <0x52>;
> };
> -
> - gpio@61 {
> - compatible = "nxp,pca9552";
> - reg = <0x61>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> };
>
> imux31: i2c@1 {
> @@ -577,15 +568,6 @@ eeprom@52 {
> compatible = "atmel,24c128";
> reg = <0x52>;
> };
> -
> - gpio@61 {
> - compatible = "nxp,pca9552";
> - reg = <0x61>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> };
> };
> };
Powered by blists - more mailing lists