linux-kernel - Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fd8cffb3212de8ae6acd7ab434a22cdd94d7279.camel@codeconstruct.com.au>
Date: Fri, 27 Sep 2024 15:58:34 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>, 
	"patrick@...cx.xyz"
	 <patrick@...cx.xyz>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>, "devicetree@...r.kernel.org"
	 <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	 <linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	 <linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
 string of adm1272

On Fri, 2024-09-27 at 06:21 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> 
> > -----Original Message-----
> > From: Andrew Jeffery <andrew@...econstruct.com.au>
> > Sent: Friday, September 27, 2024 2:01 PM
> > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
> > patrick@...cx.xyz; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> > <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Joel Stanley
> > <joel@....id.au>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> > string of adm1272
> > 
> >  [External Sender]
> > 
> >  [External Sender]
> > 
> > On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> > > 
> > > Remove the redundant space in the compatible string of adm1272.
> > 
> > In this case the space is not redundant, it's just incorrect, the compatible string
> > doesn't match any specified. Do you mind fixing the wording?
> > 
> Sure, I'll fixing the wording in v2.

Thanks.

> 
> > > 
> > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@...il.com>
> > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> > 
> > Can you please add an appropriate Fixes: tag?
> > 
> > Thanks,
> > 
> > Andrew
> > 
> Would like to ask where should I add the Fixes: tag?
> Should I add in the patch title like:
> Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272
> 
> Or should I add in the commit message?

It goes in the trailer block above your Signed-off-by tag. It will be
worth your time to review the following documentation:

- https://docs.kernel.org/process/5.Posting.html#patch-formatting-and-changelogs
- https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

The expected format and other details are described there.

Thanks,

Andrew