linux-kernel - Re: [PATCH v2 3/5] drm/msm: mdss: Add SA8775P support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2414cba4-53f2-4aec-b87b-9f8d92035bad@quicinc.com>
Date: Fri, 27 Sep 2024 12:14:16 +0530
From: Mahadevan P <quic_mahap@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <robdclark@...il.com>, <quic_abhinavk@...cinc.com>, <sean@...rly.run>,
        <marijn.suijten@...ainline.org>, <airlied@...il.com>,
        <daniel@...ll.ch>, <maarten.lankhorst@...ux.intel.com>,
        <mripard@...nel.org>, <tzimmermann@...e.de>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <swboyd@...omium.org>,
        <konrad.dybcio@...aro.org>, <danila@...xyga.com>,
        <bigfoot@...ssfun.cn>, <neil.armstrong@...aro.org>,
        <mailingradian@...il.com>, <quic_jesszhan@...cinc.com>,
        <andersson@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <freedreno@...ts.freedesktop.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_kalyant@...cinc.com>, <quic_jmadiset@...cinc.com>,
        <quic_vpolimer@...cinc.com>
Subject: Re: [PATCH v2 3/5] drm/msm: mdss: Add SA8775P support


On 9/26/2024 6:32 PM, Dmitry Baryshkov wrote:
> On Thu, Sep 26, 2024 at 04:31:35PM GMT, Mahadevan wrote:
>> Add Mobile Display Subsystem (MDSS) support for the SA8775P platform.
>>
>> Signed-off-by: Mahadevan <quic_mahap@...cinc.com>
>> ---
>>
>> [v2]
>> - Update commit message. [Dmitry]
>> - Reorder compatible string of MDSS based on alphabetical order. [Dmitry]
>> - add reg_bus_bw in msm_mdss_data. [Dmitry]
>>
>> ---
>>   drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
>> index faa88fd6eb4d..8f1d42a43bd0 100644
>> --- a/drivers/gpu/drm/msm/msm_mdss.c
>> +++ b/drivers/gpu/drm/msm/msm_mdss.c
>> @@ -573,6 +573,16 @@ static const struct msm_mdss_data qcm2290_data = {
>>   	.reg_bus_bw = 76800,
>>   };
>>   
>> +static const struct msm_mdss_data sa8775p_data = {
>> +	.ubwc_enc_version = UBWC_4_0,
>> +	.ubwc_dec_version = UBWC_4_0,
> Just 4.0 or 4.3?


UBWC version has to be 4.0 as per UBWC reference document of sa8775p.


>
>> +	.ubwc_swizzle = 4,
>> +	.ubwc_static = 1,
>> +	.highest_bank_bit = 0,
>> +	.macrotile_mode = 1,
>> +	.reg_bus_bw = 74000,
>> +};
>> +
>>   static const struct msm_mdss_data sc7180_data = {
>>   	.ubwc_enc_version = UBWC_2_0,
>>   	.ubwc_dec_version = UBWC_2_0,
>> @@ -710,6 +720,7 @@ static const struct of_device_id mdss_dt_match[] = {
>>   	{ .compatible = "qcom,mdss" },
>>   	{ .compatible = "qcom,msm8998-mdss", .data = &msm8998_data },
>>   	{ .compatible = "qcom,qcm2290-mdss", .data = &qcm2290_data },
>> +	{ .compatible = "qcom,sa8775p-mdss", .data = &sa8775p_data },
>>   	{ .compatible = "qcom,sdm670-mdss", .data = &sdm670_data },
>>   	{ .compatible = "qcom,sdm845-mdss", .data = &sdm845_data },
>>   	{ .compatible = "qcom,sc7180-mdss", .data = &sc7180_data },
>> -- 
>> 2.34.1
>>