[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0db056b9-f420-40b7-8757-ed572c65c817@oss.nxp.com>
Date: Fri, 27 Sep 2024 10:19:55 +0300
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Matthias Brugger <mbrugger@...e.com>, NXP S32 Linux Team <s32@....com>,
Chester Lin <chester62515@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>,
devicetree@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-arm-kernel@...ts.infradead.org, Conor Dooley <conor+dt@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, Christophe Lizzi
<clizzi@...hat.com>, Alberto Ruiz <aruizrui@...hat.com>,
Enric Balletbo <eballetb@...hat.com>, linux-gpio@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3
SoCs
Hi,
On 26/09/2024 20:43, Rob Herring (Arm) wrote:
>
> On Thu, 26 Sep 2024 17:31:19 +0300, Andrei Stefanescu wrote:
>> Add support for the GPIO driver of the NXP S32G2/S32G3 SoCs.
>>
>> Signed-off-by: Phu Luu An <phu.luuan@....com>
>> Signed-off-by: Larisa Grigore <larisa.grigore@....com>
>> Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@....com>
>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
>> ---
>> .../bindings/gpio/nxp,s32g2-siul2-gpio.yaml | 110 ++++++++++++++++++
>> 1 file changed, 110 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
I don't get this error locally:
$ make DT_SCHEMA_FILES=nxp,s32g2-siul2-gpio.yaml dt_binding_check
SCHEMA Documentation/devicetree/bindings/processed-schema.json
CHKDT Documentation/devicetree/bindings
LINT Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.example.dts
DTC [C] Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.example.dtb
$ pip3 show dtschema
Name: dtschema
Version: 2024.9
$ yamllint --version
yamllint 1.35.1
Lines around 25:
20 properties:
21 compatible:
22 oneOf:
23 - description: for S32G2 SoCs
24 items:
25 - const: nxp,s32g2-siul2-gpio
26 - description: for S32G3 SoCs
27 items:
28 - const: nxp,s32g3-siul2-gpio
29 - const: nxp,s32g2-siul2-gpio
I initially had the reported error but I fixed it locally by adding the following:
- description: [..]
items:
Any ideas?
Best regards,
Andrei
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240926143122.1385658-3-andrei.stefanescu@oss.nxp.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Powered by blists - more mailing lists