[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a06af01a-656b-4ef6-84a6-bc1c35d5bafa@gmail.com>
Date: Fri, 27 Sep 2024 15:59:08 +0800
From: Frank Wang <frawang.cn@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, vkoul@...nel.org,
kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
heiko@...ech.de
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, william.wu@...k-chips.com,
tim.chen@...k-chips.com, frank.wang@...k-chips.com
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add
rk3576
Hi Krzysztof,
On 2024/9/27 15:30, Krzysztof Kozlowski wrote:
> On 27/09/2024 09:01, Frank Wang wrote:
>> Hi Krzysztof,
>>
>> On 2024/9/26 22:19, Krzysztof Kozlowski wrote:
>>> On 26/09/2024 12:32, Frank Wang wrote:
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + enum:
>>>> + - rockchip,rk3576-usb2phy
>>>> + then:
>>>> + properties:
>>>> + clocks:
>>>> + minItems: 3
>>>> + maxItems: 3
>>> Read one more time the example I gave you. Top-level constraints are
>>> saying max one clock.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Sorry for overlooking this, I will set both "clocks" and "clock-names"
>> to true, and add the else case below the above codes for the "old" SoCs.
>> Just like the below.
>>
>> - clocks:
>> - maxItems: 1
>> + clocks: true
>>
>> - clock-names:
>> - const: phyclk
>> + clock-names: true
> For the third time, read the code I gave you. Do you see something like
> this there? Why doing all the time something different than existing code?
Refer to the link you sent me that I must add minItems property for
clocks, just like the below codes:
@@ -35,7 +35,8 @@ properties:
const: 0
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
That can pass dt_binding and dtb checking, however, "clocks" is the
optional property for some old Rockchip PHYs, I am not sure is it right
to force set minItems as 1 .
If just keep maxItems, the dt_binding checking is failure.
Best regards,
Frank
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists