linux-kernel - Re: [PATCH v2 1/2] rust: add untrusted data abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00ca48e4-1b4a-496d-a06b-3c12a9ef2d14@proton.me>
Date: Fri, 27 Sep 2024 09:06:45 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: kernel test robot <lkp@...el.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, Greg KH <greg@...ah.com>, Simona Vetter <simona.vetter@...ll.ch>, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rust: add untrusted data abstraction

On 27.09.24 10:39, Miguel Ojeda wrote:
> On Fri, Sep 27, 2024 at 12:15 AM Benno Lossin <benno.lossin@...ton.me> wrote:
>>
>> Personally, I would prefer adding a symbol. Since if we allow it, then
>> it might take a long time until the code is removed once we increase the
>> minimum version.
>>
>> It would be best, if it produces an error when we raise the minimum
>> version beyond the one represented by the symbol. Is that already the
>> case?
> 
> No -- that is a nice idea that I guess could be implemented in Kconfig
> somewhere (i.e. when checking conditions). However, one of the common
> things to do when upgrading the minimum is to review/clean the
> `*_VERSION` uses anyway (and they may occur outside Kconfig files
> too), and also sometimes one wants to upgrade a minimum without doing
> the cleanups immediately (e.g. the recently proposed GCC 8.1 upgrade).
> 
>> Gave it a try and I also can't reproduce the error there...
> 
> Hmm... I think CE uses the Rust-provided binaries (and I guess the
> playground too). Do you have a link ("Share" in CE)?

Here you go: https://godbolt.org/z/qE8E9M56c

The error that I get locally:

    error: unreachable pattern
     --> src/main.rs:8:9
      |
    8 |         Err(e) => match e {},
      |         ^^^^^^ matches no values because `Infallible` is uninhabited
      |
      = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types
    note: the lint level is defined here
     --> src/main.rs:1:9
      |
    1 | #![deny(unreachable_patterns)]
      |         ^^^^^^^^^^^^^^^^^^^^
    
    error: could not compile `rust` (bin "rust") due to 1 previous error

---
Cheers,
Benno