linux-kernel - Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tpjxumq75zjg6m2ucqat6vbzvtnku3msnqc6xpmizwtzdkwxwr@deqo4dbretch>
Date: Fri, 27 Sep 2024 11:35:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Caleb Connolly <caleb.connolly@...aro.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop
 incorrect "#interrupt-cells" from example

On Thu, Sep 26, 2024 at 04:37:26PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells". However, the PMIC parent node is not an interrupt
> controller at all, so the "#interrupt-cells" is erroneous.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> v2:
>  - Drop "#interrupt-cells" rather than add "interrupt-controller"

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof