linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: add attiny_rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3885598.FjKLVJYuhi@phil>
Date: Fri, 27 Sep 2024 11:39:49 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Jakob Unterwurzacher <jakobunt@...il.com>,
 Quentin Schulz <quentin.schulz@...rry.de>
Cc: linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 Jakob Unterwurzacher <jakob.unterwurzacher@...rry.de>
Subject: Re: [PATCH v2] arm64: dts: rockchip: add attiny_rst_gate to Ringneck

Am Donnerstag, 26. September 2024, 15:24:03 CEST schrieb Quentin Schulz:
> Hi Jakob,
> 
> On 9/26/24 3:20 PM, Jakob Unterwurzacher wrote:
> > Ringneck v1.4 can contain (placement option) an on-board ATtiny
> > microcontroller instead of an STM32. In normal operation, this
> > is transparent to the software, as both microcontrollers emulate
> > the same ICs (amc6821 and isl1208).
> > 
> > For flashing the ATtiny, the SWITCH_REG1 regulator of the board's PMIC is
> > used to enable the ATtiny UPDI debug interface. If the STM32 is placed, or if
> > we are running on an older Ringneck revision, SWITCH_REG1 is not connected
> > and has no effect.
> > 
> > Add attiny-updi-gate-regulator so userspace can control it via sysfs
> > (needs CONFIG_REGULATOR_USERSPACE_CONSUMER):
> > 
> >    echo enabled > /sys/devices/platform/attiny-updi-gate-regulator/state
> > 
> > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@...rry.de>
> > Tested-by: Quentin Schulz <quentin.schulz@...rry.de>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@...rry.de>
> 
> This is a candidate for backporting to stable branches as well I assume, 
> @Heiko?

That is more on the darker side of gray here.

Looking at the stable-kernel-rules [0] the criteria is
  "It must either fix a real bug that bothers people or just add a device ID"

This change instead is adding a new feature to allow said flashing from a
running system.

sidenote: please don't post new versions as replies to previous versions,
as that confuses tooling a lot.

Heiko


[0] https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html