[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org>
Date: Fri, 27 Sep 2024 11:52:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Wang <frawang.cn@...il.com>, vkoul@...nel.org, kishon@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, william.wu@...k-chips.com,
tim.chen@...k-chips.com, frank.wang@...k-chips.com
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add
rk3576
On 27/09/2024 09:59, Frank Wang wrote:
>>>
>>> - clocks:
>>> - maxItems: 1
>>> + clocks: true
>>>
>>> - clock-names:
>>> - const: phyclk
>>> + clock-names: true
>> For the third time, read the code I gave you. Do you see something like
>> this there? Why doing all the time something different than existing code?
>
> Refer to the link you sent me that I must add minItems property for
> clocks, just like the below codes:
>
> @@ -35,7 +35,8 @@ properties:
> const: 0
>
> clocks:
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
Yes, for all variable properties, so also names.
>
> That can pass dt_binding and dtb checking, however, "clocks" is the
> optional property for some old Rockchip PHYs, I am not sure is it right
> to force set minItems as 1 .
> If just keep maxItems, the dt_binding checking is failure.
Please specify the question you want to ask.
Best regards,
Krzysztof
Powered by blists - more mailing lists