[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aeb90ae8-8572-434a-82bc-3d218d3affb8@xs4all.nl>
Date: Fri, 27 Sep 2024 12:09:56 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Ricardo Ribalda <ribalda@...omium.org>, Benoit Parrot <bparrot@...com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Bingbu Cao <bingbu.cao@...el.com>, Tianshu Qiu <tian.shu.qiu@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans de Goede <hdegoede@...hat.com>, Andy Shevchenko <andy@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 3/3] media: atomisp: Use max() macros
On 27/09/2024 12:02, Ricardo Ribalda wrote:
> The max() macro produce nicer code and also fixes the following cocci
> errors:
>
> drivers/staging/media/atomisp/pci/sh_css_frac.h:40:17-18: WARNING opportunity for max()
> drivers/staging/media/atomisp/pci/sh_css_frac.h:50:17-18: WARNING opportunity for max()
Subject and commit message is now out of sync with the code.
Hans
>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
> drivers/staging/media/atomisp/pci/sh_css_frac.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_frac.h b/drivers/staging/media/atomisp/pci/sh_css_frac.h
> index 8ba65161f7a9..3191d2858f59 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_frac.h
> +++ b/drivers/staging/media/atomisp/pci/sh_css_frac.h
> @@ -37,7 +37,8 @@ static inline int sDIGIT_FITTING(int v, int a, int b)
> int fit_shift = sFRACTION_BITS_FITTING(a) - b;
>
> v >>= sSHIFT;
> - v >>= fit_shift > 0 ? fit_shift : 0;
> + if (fit_shift > 0)
> + v >>= fit_shift;
>
> return clamp_t(int, v, sISP_VAL_MIN, sISP_VAL_MAX);
> }
> @@ -47,7 +48,8 @@ static inline unsigned int uDIGIT_FITTING(unsigned int v, int a, int b)
> int fit_shift = uFRACTION_BITS_FITTING(a) - b;
>
> v >>= uSHIFT;
> - v >>= fit_shift > 0 ? fit_shift : 0;
> + if (fit_shift > 0)
> + v >>= fit_shift;
>
> return clamp_t(unsigned int, v, uISP_VAL_MIN, uISP_VAL_MAX);
> }
>
Powered by blists - more mailing lists