linux-kernel - Re: [PATCH v2 1/3] media: ti: cal: Use str_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiDSCvF4g7H77Tuy=YUfCG5xYxcb8R8oTsvCjSt65zPAsepog@mail.gmail.com>
Date: Fri, 27 Sep 2024 12:16:34 +0200
From: Ricardo Ribalda <ribalda@...omium.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Benoit Parrot <bparrot@...com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Bingbu Cao <bingbu.cao@...el.com>, 
	Tianshu Qiu <tian.shu.qiu@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Hans de Goede <hdegoede@...hat.com>, Andy Shevchenko <andy@...nel.org>, 
	Hans Verkuil <hverkuil-cisco@...all.nl>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] media: ti: cal: Use str_up_down()

Hi Andy

On Fri, 27 Sept 2024 at 12:10, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Fri, Sep 27, 2024 at 1:02 PM Ricardo Ribalda <ribalda@...omium.org> wrote:
> >
> > The str_up_down() helper simplifies the code and fixes the following cocci
> > warning:
> >
> > drivers/media/platform/ti/cal/cal-camerarx.c:194:3-9: opportunity for str_up_down(enable)
>
> ...
>
> >         if (i == 10)
> >                 phy_err(phy, "Failed to power %s complexio\n",
> > -                       enable ? "up" : "down");
> > +                       str_up_down(enable);
>
> You never tested this, do not bother to send untested material, please!

Do you mean tested in real hardware or compile test it?

I did test it:
https://gitlab.freedesktop.org/linux-media/users/ribalda/-/commits/test-newlinus

But obviously we are not building that file :S. Let me figure out why
did this happened

Sorry for the noise

>
> --
> With Best Regards,
> Andy Shevchenko



-- 
Ricardo Ribalda