linux-kernel - Re: [PATCH v2 0/8] binder: several fixes for frozen notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLggjvWchAeSRXvw=+qNVEBMKBp-7fAk5z3JLSuc5aUz5=g@mail.gmail.com>
Date: Fri, 27 Sep 2024 12:20:45 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	kernel-team@...roid.com, stable@...r.kernel.org, 
	Yu-Ting Tseng <yutingtseng@...gle.com>, Todd Kjos <tkjos@...gle.com>, 
	Martijn Coenen <maco@...gle.com>, Arve Hjønnevåg <arve@...roid.com>, 
	Viktor Martensson <vmartensson@...gle.com>
Subject: Re: [PATCH v2 0/8] binder: several fixes for frozen notification

On Fri, Sep 27, 2024 at 1:36 AM Carlos Llamas <cmllamas@...gle.com> wrote:
>
> These are all fixes for the frozen notification patch [1], which as of
> today hasn't landed in mainline yet. As such, this patchset is rebased
> on top of the char-misc-next branch.
>
> [1] https://lore.kernel.org/all/20240709070047.4055369-2-yutingtseng@google.com/

I looked for other inconsistencies between death and freeze
notifications. I found two:

binder_free_proc has this line:
BUG_ON(!list_empty(&proc->delivered_death));

The top comment has this line:
 * 3) proc->inner_lock : protects the thread and node lists
 *    (proc->threads, proc->waiting_threads, proc->nodes)
 *    and all todo lists associated with the binder_proc
 *    (proc->todo, thread->todo, proc->delivered_death and
 *    node->async_todo), as well as thread->transaction_stack
 *    binder_inner_proc_lock() and binder_inner_proc_unlock()
 *    are used to acq/rel

Both mention delivered_death but not freeze.

Alice