linux-kernel - RE: [PATCH v4 05/11] drm/bridge: it6505: increase supports of HDCP repeater ksv devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79e5e8479b2b4563b2ce4f4a252b2586@ite.com.tw>
Date: Fri, 27 Sep 2024 02:18:54 +0000
From: <Hermes.Wu@....com.tw>
To: <dmitry.baryshkov@...aro.org>
CC: <Kenneth.Hung@....com.tw>, <andrzej.hajda@...el.com>,
        <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
        <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
        <jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
        <mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
        <simona@...ll.ch>, <angelogioacchino.delregno@...labora.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 05/11] drm/bridge: it6505: increase supports of HDCP
 repeater ksv devices

>
>-----Original Message-----
>From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
>Sent: Thursday, September 26, 2024 4:07 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>
>Cc: Kenneth Hung (洪家倫) <Kenneth.Hung@....com.tw>; Andrzej Hajda <andrzej.hajda@...el.com>; Neil Armstrong <neil.armstrong@...aro.org>; Robert Foss <rfoss@...nel.org>; Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>; Jernej Skrabec <jernej.skrabec@...il.com>; Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>; David Airlie <airlied@...il.com>; Simona Vetter <simona@...ll.ch>; Allen Chen <allen.chen@....com.tw>; AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>; open list:DRM DRIVERS <dri-devel@...ts.freedesktop.org>; open list <linux-kernel@...r.kernel.org>
>Subject: Re: [PATCH v4 05/11] drm/bridge: it6505: increase supports of HDCP repeater ksv devices
>
>On Thu, Sep 26, 2024 at 03:50:14PM GMT, Hermes Wu wrote:
>> From: Hermes Wu <Hermes.wu@....com.tw>
>> 
>> A HDCP source shall support max downstream device to 127.
>> 
>> Change definition of MAX_HDCP_DOWN_STREAM_COUNT to 127
>
>This results in struct it6505 growth by ~0.5 KiB. Please mention it in the commit message.
>
>Is it really required to have sha1_input in the constantly allocated structure? I think it's a temporary data, which isn't necessary after processing.

Change sha1_input with dynamic memory into one commit or 

change to use temporary data in one and change definition of MAX_HDCP_DOWN_STREAM_COUN in another?

>> 
>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>> Signed-off-by: Hermes Wu <Hermes.wu@....com.tw>
>> ---
>>  drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c 
>> b/drivers/gpu/drm/bridge/ite-it6505.c
>> index d1f5220e04a6..5d5ce12cd054 100644
>> --- a/drivers/gpu/drm/bridge/ite-it6505.c
>> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
>> @@ -296,7 +296,7 @@
>>  #define MAX_LANE_COUNT 4
>>  #define MAX_LINK_RATE HBR
>>  #define AUTO_TRAIN_RETRY 3
>> -#define MAX_HDCP_DOWN_STREAM_COUNT 10
>> +#define MAX_HDCP_DOWN_STREAM_COUNT 127
>>  #define MAX_CR_LEVEL 0x03
>>  #define MAX_EQ_LEVEL 0x03
>>  #define AUX_WAIT_TIMEOUT_MS 15
>> --
>> 2.34.1
>> 
>
>-- 
>With best wishes
>Dmitry
>

BR,
Hermes