[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240927125745.38367-1-dima.fedrau@gmail.com>
Date: Fri, 27 Sep 2024 14:57:43 +0200
From: Dimitri Fedrau <dima.fedrau@...il.com>
To:
Cc: Dimitri Fedrau <dima.fedrau@...il.com>,
Uwe Kleine-König <ukleinek@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-pwm@...r.kernel.org,
devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v6 0/2] pwm: add support for NXPs high-side switch MC33XS2410
The MC33XS2410 is a four channel high-side switch. Featuring advanced
monitoring and control function, the device is operational from 3.0 V to
60 V. The device is controlled by SPI port for configuration.
Changes in V2:
- fix title in devicetree binding
- fix commit message in devicetree binding patch
- remove external clock from pwms and create clocks property
- switch to unevaluatedProperties: false
- add missing properties for complete example:
- pwm-names
- pwms
- interrupts
- clocks
Changes in V3:
- Add description of the general behaviour of the device (limitations)
- Drop unused defines
- Add ranges comments for defines with parameters
- Drop MC33XS2410_PERIOD_MAX, MC33XS2410_PERIOD_MIN defines
- Drop mc33xs2410_period variable
- Round down when calculating period and duty cycle
- Use switch instead of loop when calculating frequency
- Removed ret variable in mc33xs2410_pwm_get_freq
- Handle all accesses in a single call to spi_sync_transfer
- Fix comments in function mc33xs2410_pwm_get_period
- Fix call pwm_set_relative_duty_cycle(state, ret, 255), instead
pwm_set_relative_duty_cycle(state, val[1] + 1, 256);
- Use devm_pwmchip_alloc
- Fix typo s/Transitition/Transition/
- Drop driver_data
- Removed patch for direct inputs from series
- Tested with PWM_DEBUG enabled, didn't before !
Changes in V4:
- removed include of math.h, already included in math64.h
- removed include of mutex.h, no mutexes are used
- added include of bitfield.h(FIELD_GET, FIELD_PREP), fixes errors
discovered by kernel test robot
- cast parameters in DIV_ROUND_UP to u32, fixes errors discovered by
kernel test robot
Changes in V5:
- Fix comment in mc33xs2410_pwm_get_freq, selecting steps instead of
period
- Add comment in mc33xs2410_pwm_get_relative_duty_cycle that duty_cycle
cannot overflow and and period is not zero, guaranteed by the caller
- Hardware emits a low level when disabled, disable if duty_cycle = 0 is
requested.
- Fix complaints when PWM_DEBUG enabled, round-down division in
mc33xs2410_pwm_apply and round-up in mc33xs2410_pwm_get_state.
- Add comment for disabling watchdog in probe
Changes in V6:
- Add link to manual
- Redefine MC33XS2410_GLB_CTRL_MODE_MASK as MC33XS2410_GLB_CTRL_MODE and
MC33XS2410_GLB_CTRL_NORMAL_MODE as MC33XS2410_GLB_CTRL_MODE_NORMAL
- Remove define MC33XS2410_MIN_PERIOD_STEP(x) as there is no need for
parameters and use instead MC33XS2410_MIN_PERIOD
- Rename function to_pwm_mc33xs2410_chip to mc33xs2410_from_chip
- Add comment in mc33xs2410_pwm_get_freq why count should be rounded up
- Fix incorrect comment in mc33xs2410_pwm_get_period
- Rename steps variable to doubled_steps in function
mc33xs2410_pwm_get_freq
- remove cast in mc33xs2410_pwm_set_relative_duty_cycle
- remove duty_cycle from if in mc33xs2410_pwm_set_relative_duty_cycle
Dimitri Fedrau (2):
dt-bindings: pwm: add support for MC33XS2410
pwm: add support for NXPs high-side switch MC33XS2410
.../bindings/pwm/nxp,mc33xs2410.yaml | 118 +++++
drivers/pwm/Kconfig | 12 +
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-mc33xs2410.c | 422 ++++++++++++++++++
4 files changed, 553 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/nxp,mc33xs2410.yaml
create mode 100644 drivers/pwm/pwm-mc33xs2410.c
--
2.39.5
Powered by blists - more mailing lists