linux-kernel - Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <93d9ffbe466ff61d5426b6f158a4b8464f56824d.camel@mediatek.com>
Date: Fri, 27 Sep 2024 02:27:14 +0000
From: Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
To: "conor@...nel.org" <conor@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
	Macpaul Lin (林智斌) <Macpaul.Lin@...iatek.com>
CC: Pablo Sun (孫毓翔) <pablo.sun@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris-qj Chen (陳奇進)
	<Chris-qj.Chen@...iatek.com>, Bear Wang (萩原惟德)
	<bear.wang@...iatek.com>, "wenst@...omium.org" <wenst@...omium.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	Macross Chen (陳賢碩) <macross.chen@...iatek.com>,
	"joro@...tes.org" <joro@...tes.org>, "robin.murphy@....com"
	<robin.murphy@....com>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"macpaul@...il.com" <macpaul@...il.com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	Yong Wu (吴勇) <Yong.Wu@...iatek.com>,
	"airlied@...il.com" <airlied@...il.com>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Alexandre Mergnat <amergnat@...libre.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Sen Chu (储森)
	<Sen.Chu@...iatek.com>, "will@...nel.org" <will@...nel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count
 constraint for new SoCs

On Thu, 2024-09-26 at 11:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 25/09/24 16:34, Conor Dooley ha scritto:
> > On Wed, Sep 25, 2024 at 04:42:59PM +0800, Macpaul Lin wrote:
> > > 
> > > On 9/25/24 00:00, Conor Dooley wrote:
> > > > On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del
> > > > Regno wrote:
> > > > > Il 24/09/24 12:31, Macpaul Lin ha scritto:
> > > > > > The display node in mt8195.dtsi was triggering a CHECK_DTBS
> > > > > > error due
> > > > > > to an excessively long 'clocks' property:
> > > > > >      display@...06000: clocks: [[31, 14], [31, 43], [31,
> > > > > > 44]] is too long
> > > > > > 
> > > > > > To resolve this issue, add "maxItems: 3" to the 'clocks'
> > > > > > property in
> > > > > > the DT schema.
> > > > > > 
> > > > > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp:
> > > > > > split each block to individual yaml")
> > > > > > Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> > > > > > ---
> > > > > >     .../devicetree/bindings/display/mediatek/mediatek,split
> > > > > > .yaml     | 1 +
> > > > > >     1 file changed, 1 insertion(+)
> > > > > > 
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/display/mediatek/mediat
> > > > > > ek,split.yaml
> > > > > > b/Documentation/devicetree/bindings/display/mediatek/mediat
> > > > > > ek,split.yaml
> > > > > > index e4affc854f3d..42d2d483cc29 100644
> > > > > > ---
> > > > > > a/Documentation/devicetree/bindings/display/mediatek/mediat
> > > > > > ek,split.yaml
> > > > > > +++
> > > > > > b/Documentation/devicetree/bindings/display/mediatek/mediat
> > > > > > ek,split.yaml
> > > > > > @@ -57,6 +57,7 @@ properties:
> > > > > >       clocks:
> > > > > >         items:
> > > > > >           - description: SPLIT Clock
> > > > > 
> > > > > That's at least confusing (granted that it works) - either
> > > > > add a description for
> > > > > each clock and then set `minItems: 1` (preferred), or remove
> > > > > this "SPLIT Clock"
> > > > > description and allow a maximum of 3 clocks.
> > > > > 
> > > > > Removing the description can be done - IMO - because "SPLIT
> > > > > Clock" is, well,
> > > > > saying that the SPLIT block gets a SPLIT clock ... stating
> > > > > the obvious, anyway.
> > > > 
> > > > Right, but what are the other two new clocks? Are they as
> > > > obvious?
> > > > There's no clock-names here to give any more information as to
> > > > what the
> > > > other clocks are supposed to be.
> > > > 
> > > > Kinda unrelated, but I think that "SPLIT Clock" probably isn't
> > > > what the
> > > > name of the clock in the IP block is anyway, sounds more like
> > > > the name
> > > > for it on the provider end..
> > > 
> > > 
 * Thanks for the suggestions. I think Moudy could help on the new
   fixes
> > > for both DT schem and mt8195.dtsi. This patch could be separated
> > > from
> > > origin patch set.
> > 
> > Not sure what you mean about separating it, if you mean correcting
> > the
> > description for the split clock sure. The other stuff I mentioned
> > needs
> > to be resolved before I'm willing to ack this.
> 
> He means separating this patch from the rest of the series that he
> pushed - which
> is okay, as it's a bit mixed anyway :-)
> 
> Besides ... Moudy, can you please help to clarify the description of
> those clocks?
> 
> Cheers,
> Angelo

Greetings,

May I address the check error by adding 2 functional descriptions and
specifying 'minIeims: 1' for this property, and apply the limit by
setting 'maxItems: 3' in MT8195 additional condition?

Sincerely,
Moudy Ho