linux-kernel - Re: [PATCH v5 19/19] virt: arm-cca-guest: TSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56886e2e-b5ce-4753-b36f-43d1d7ac427b@arm.com>
Date: Fri, 27 Sep 2024 16:21:19 +0100
From: Steven Price <steven.price@....com>
To: "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, kvm@...r.kernel.org,
 kvmarm@...ts.linux.dev
Cc: Catalin Marinas <catalin.marinas@....com>, Marc Zyngier <maz@...nel.org>,
 Will Deacon <will@...nel.org>, James Morse <james.morse@....com>,
 Oliver Upton <oliver.upton@...ux.dev>,
 Suzuki K Poulose <suzuki.poulose@....com>, Zenghui Yu
 <yuzenghui@...wei.com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Joey Gouly <joey.gouly@....com>,
 Alexandru Elisei <alexandru.elisei@....com>,
 Christoffer Dall <christoffer.dall@....com>, Fuad Tabba <tabba@...gle.com>,
 linux-coco@...ts.linux.dev,
 Ganapatrao Kulkarni <gankulkarni@...amperecomputing.com>,
 Gavin Shan <gshan@...hat.com>, Shanker Donthineni <sdonthineni@...dia.com>,
 Alper Gun <alpergun@...gle.com>, Sami Mujawar <sami.mujawar@....com>
Subject: Re: [PATCH v5 19/19] virt: arm-cca-guest: TSM_REPORT support for
 realms

On 02/09/2024 04:53, Aneesh Kumar K.V wrote:
> Steven Price <steven.price@....com> writes:
> 
>> From: Sami Mujawar <sami.mujawar@....com>
>  
> ...
>  
>> --- /dev/null
>> +++ b/drivers/virt/coco/arm-cca-guest/Kconfig
>> @@ -0,0 +1,11 @@
>> +config ARM_CCA_GUEST
>> +	tristate "Arm CCA Guest driver"
>> +	depends on ARM64
>> +	default m
>> +	select TSM_REPORTS
>> +	help
>> +	  The driver provides userspace interface to request and
>> +	  attestation report from the Realm Management Monitor(RMM).
>> +
>> +	  If you choose 'M' here, this module will be called
>> +	  arm-cca-guest.
>>
> 
> Can we rename the generic Kconfig variable to ARM_CCA_TSM_REPORT?. Also
> should the directory be arm64-cca-guest?

This matches the existing sev-guest and tdx-guest directories (and
SEV_GUEST/TDX_GUEST_DRIVER kconfig), although I agree it's not great
naming as it stands.

But I'm also wondering if this will one day expand to include some other
communication with the RMM. For example I know it's been discussed
whether the guest should have involvement with firmware updates or
migration to another host. So there's a reasonable chance we could end
up renaming it back to a general "arm_cca_guest" if it grows more
capabilities in the future.

Steve