linux-kernel - Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D4H6EYM973NS.13D8BVWVTVO2D@b1n.io>
Date: Fri, 27 Sep 2024 15:36:42 +0000
From: "Xingquan Liu" <b1n@....io>
To: "Dan Carpenter" <dan.carpenter@...aro.org>
Cc: "Florian Schilhabel" <florian.c.schilhabel@...glemail.com>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>,
 <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings

On Fri Sep 27, 2024 at 11:26 PM CST, Dan Carpenter wrote:
> On Fri, Sep 27, 2024 at 11:16:36PM +0800, Xingquan Liu wrote:
> > Fix all unnecessary parentheses warnings in checkpath.
> > 
> > Signed-off-by: Xingquan Liu <b1n@....io>
> > ---
> > I ran clang-format additionally because I noticed the Linux community
> > recommends submitting code formatting patches along with other patches.
>
> Probably avoid running clang-format.  If we wanted to do that, we could have
> done it already.

Ok.

> > 
> > I'm not sure if there are any issues with this.
>
> This patch does way too many things at once.  This is a long way away from being
> something we would even look at.

I wanna fix all unnecessary parentheses warnings in one patch, is it ok?

-- 
Xingquan Liu


Download attachment "signature.asc" of type "application/pgp-signature" (351 bytes)