linux-kernel - Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D4H6RX1ZCSQ8.1BQ8LW44D65X1@b1n.io>
Date: Fri, 27 Sep 2024 15:53:37 +0000
From: "Xingquan Liu" <b1n@....io>
To: "Dan Carpenter" <dan.carpenter@...aro.org>
Cc: "Florian Schilhabel" <florian.c.schilhabel@...glemail.com>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>,
 <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings

On Fri Sep 27, 2024 at 11:45 PM CST, Dan Carpenter wrote:
> Greg doesn't agree with checkpatch about unnecessary parentheses.  If the code
> looks like this:
>
> 	if ((a == b) || (b == c)) {
>
> then just ignore checkpatch.  However if the code looks like:
>
> 	p = &(foo);
>
> Then change it to:
>
> 	p = &foo;
>
> This sort of change would need to be split up by driver instead of all of
> driver/staging.  So it would be a series of patches.  You don't need to split
> it up by file.  Split it by driver.

Thanks, this information is important.

-- 
Xingquan Liu


Download attachment "signature.asc" of type "application/pgp-signature" (351 bytes)