linux-kernel - Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3A637158-BA4B-49F5-8119-337FAC944915@live.com>
Date: Fri, 27 Sep 2024 16:48:23 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "mripard@...nel.org" <mripard@...nel.org>
CC: "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	Jiri Kosina <jikos@...nel.org>, "bentiss@...nel.org" <bentiss@...nel.org>,
	Thomas Weißschuh <thomas@...ch.de>, Orlando Chamberlain
	<orlandoch.dev@...il.com>, Kerem Karabay <kekrby@...il.com>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86
 Macs



> On 27 Sep 2024, at 1:12 PM, mripard@...nel.org wrote:
> 
> On Sat, Aug 17, 2024 at 11:52:22AM GMT, Aditya Garg wrote:
>> From: Kerem Karabay <kekrby@...il.com>
>> 
>> The Touch Bars found on x86 Macs support two USB configurations: one
>> where the device presents itself as a HID keyboard and can display
>> predefined sets of keys, and one where the operating system has full
>> control over what is displayed. This commit adds support for the display
>> functionality of the second configuration.
>> 
>> Note that this driver has only been tested on T2 Macs, and only includes
>> the USB device ID for these devices. Testing on T1 Macs would be
>> appreciated.
>> 
>> Credit goes to @imbushuo on GitHub for reverse engineering most of the
>> protocol.
>> 
>> Signed-off-by: Kerem Karabay <kekrby@...il.com>
>> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
>> ---
>> MAINTAINERS                       |   6 +
>> drivers/gpu/drm/tiny/Kconfig      |  12 +
>> drivers/gpu/drm/tiny/Makefile     |   1 +
>> drivers/gpu/drm/tiny/appletbdrm.c | 624 ++++++++++++++++++++++++++++++
>> 4 files changed, 643 insertions(+)
>> create mode 100644 drivers/gpu/drm/tiny/appletbdrm.c
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8766f3e5e..2665e6c57 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -6889,6 +6889,12 @@ S: Supported
>> T: git https://gitlab.freedesktop.org/drm/misc/kernel.git
>> F: drivers/gpu/drm/sun4i/sun8i*
>> 
>> +DRM DRIVER FOR APPLE TOUCH BARS
>> +M: Kerem Karabay <kekrby@...il.com>
>> +L: dri-devel@...ts.freedesktop.org
>> +S: Maintained
>> +F: drivers/gpu/drm/tiny/appletbdrm.c

Hi Maxime

> 
> How do you plan on maintaining it? If you want to do so through drm-misc
> (and you should), you need to list the gitlab repo here.

Sorry for the oversight. Indeed the maintainer needs to be changed here, since Kerem is no longer active on t2linux, the organisation I am working with.

If a maintainer is really needed, I’m fine with taking the role. I can also request other people from t2linux to take up the role as well. If its optional, I’ll remove it
> 
> Also, I haven't seen Kerem take part of the discussion at all. Are they
> ok with taking on the maintainer's role?
> 
> It's really clear to me either why this needs to be going through hid at
> all. Is it not standalone?

The hid patchset has various patches to hid-multitouch with are needed along with the drm driver.

Thanks
Aditya