[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20240927181637.19941-1-quic_pintu@quicinc.com>
Date: Fri, 27 Sep 2024 23:46:37 +0530
From: Pintu Kumar <quic_pintu@...cinc.com>
To: <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
<linux-kernel@...r.kernel.org>
CC: <shuah@...nel.org>, <skhan@...uxfoundation.org>, <pintu.ping@...il.com>,
Pintu Kumar <quic_pintu@...cinc.com>
Subject: [PATCH] mm/cma: fix useless return in void function
There is a unnecessary return statement at the end of
void function cma_activate_area.
This can be dropped.
While at it, also fix another warning related to unsigned.
These are reported by checkpatch as well.
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+unsigned cma_area_count;
WARNING: void function return statements are not generally useful
+ return;
+}
Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
---
mm/cma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/cma.c b/mm/cma.c
index 2d9fae939283..c5869d0001ad 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -32,7 +32,7 @@
#include "cma.h"
struct cma cma_areas[MAX_CMA_AREAS];
-unsigned cma_area_count;
+unsigned int cma_area_count;
static DEFINE_MUTEX(cma_mutex);
phys_addr_t cma_get_base(const struct cma *cma)
@@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
totalcma_pages -= cma->count;
cma->count = 0;
pr_err("CMA area %s could not be activated\n", cma->name);
- return;
}
static int __init cma_init_reserved_areas(void)
--
2.17.1
Powered by blists - more mailing lists