[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHk-=wikugk2soi_2OFz1k27qjjYMQ140ZXWeOh8_9iSxpr=PQ@mail.gmail.com>
Date: Fri, 27 Sep 2024 12:47:16 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Amir Goldstein <amir73il@...il.com>
Cc: Leo Stone <leocstone@...il.com>,
syzbot+d9efec94dcbfa0de1c07@...kaller.appspotmail.com,
linux-kernel@...r.kernel.org, linux-unionfs@...r.kernel.org,
miklos@...redi.hu, syzkaller-bugs@...glegroups.com, skhan@...uxfoundation.org,
anupnewsmail@...il.com, Christian Brauner <brauner@...nel.org>,
Al Viro <viro@...iv.linux.org.uk>, linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [syzbot] [overlayfs?] general protection fault in ovl_llseek
On Fri, 27 Sept 2024 at 05:41, Amir Goldstein <amir73il@...il.com> wrote:
>
> Too quick to send. I messed up the Fixes: tag.
> Now fixed.
Applied.
However, just for the future: please send patches that you expect me
to apply with a very explicit subject line to that effect.
I get too much email, and hey, I do try to read it all (even if I
don't answer), but I'm really really good at scanning my emails
quickly.
In other words: sometimes I'm a bit *too* good at the "quickly" part,
and end up missing the fact that "oh, there was a patch there that I
need to actually react to and apply".
That has become more true over the years as the individual patch count
has gone down, and *most* of what I do is git pulls, and most of the
emailed patches I see tend to be things that are for review, not
application.
Yes, I picked it up this time. And maybe I even pick up on these
things *most* of the time.
But I still strongly suspect that to make it more likely that I don't
miss anything, you make the subject line some big clue-bat to my head
like having "[PATCH-for-linus]" header.
Because even just a "[PATCH]" is likely to trigger my "patch review"
logic rather than something I'm actually expected to apply, just
because I see *so* many patches fly by.
This was your daily "Linus is all kinds of disorganized and
incompetent" notification. Making things obvious to me is always a
good thing. It's why those "[GIT PULL]" subject lines help not just
pr-tracker-bot, but also me.
Thanks,
Linus
Powered by blists - more mailing lists