linux-kernel - Re: [PATCH] sched_ext: Call put_task_struct() only once in scx_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvcRZt4foaB1IjTT@slm.duckdns.org>
Date: Fri, 27 Sep 2024 10:11:18 -1000
From: Tejun Heo <tj@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org, Barret Rhoden <brho@...gle.com>,
	Ben Segall <bsegall@...gle.com>, David Vernet <void@...ifault.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Ingo Molnar <mingo@...hat.com>, Josh Don <joshdon@...gle.com>,
	Juri Lelli <juri.lelli@...hat.com>, Hao Luo <haoluo@...gle.com>,
	Mel Gorman <mgorman@...e.de>, Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Valentin Schneider <vschneid@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrea Righi <andrea.righi@...onical.com>
Subject: Re: [PATCH] sched_ext: Call put_task_struct() only once in
 scx_ops_enable()

On Thu, Sep 26, 2024 at 03:30:12PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 26 Sep 2024 14:51:07 +0200
> 
> A put_task_struct() call was immediately used after a return value check
> for a scx_ops_init_task() call in this function implementation.
> Thus call such a function only once instead directly before the check.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

This no longer applies after 9753358a6a2b ("sched_ext: Fix SCX_TASK_INIT ->
SCX_TASK_READY transitions in scx_ops_enable()").

Thanks.

-- 
tejun