linux-kernel - Re: [PATCH] dt-bindings: usb: add missing compatible arraylist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c71ef80-0a4a-490b-be61-bb7641b9ac88@kernel.org>
Date: Sat, 28 Sep 2024 10:58:14 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Karan Sanghavi <karansanghvi98@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] dt-bindings: usb: add missing compatible arraylist



On 28/09/2024 10:39, Karan Sanghavi wrote:
> On Mon, 23 Sept 2024 at 17:23, Roger Quadros <rogerq@...nel.org> wrote:
>>
>> On 22/09/2024 20:00, Karan Sanghavi wrote:
>>> Added the vice versa order for compatible property in the yaml file so
>>> that the dtb can parse for the order mentioned in the dts file
>>> k3-am642-sk.dts for ti,j721e-usb.yaml
>>
>> k3-am642-sk.dts does not introduce any nodes with the said compatibles.
>>
>> "ti,am64-usb" compatible is introduced by k3-am642-main.dtsi.
>> There is only one compatible introduced so there is nothing to do about
>> order here.
>>
>> i.e.
>>         usbss0: cdns-usb@...0000 {
>>                 compatible = "ti,am64-usb";
>>                 reg = <0x00 0xf900000 0x00 0x100>;
>>
>> What is the functional problem you are facing? Maybe then someone
>> can point you in the right direction.
>>
> 
> Sorry for mentioning the wrong file name; yes,
> the problem is in k3-am64-main.dtsi file as mentioned below
> 
>  usbss0: cdns-usb@...0000 {
>  766                 compatible = "ti,am64-usb", "ti,j721e-usb";
>  767                 reg = <0x00 0xf900000 0x00 0x100>;
> 

Which tree are you looking at?

https://elixir.bootlin.com/linux/v6.11/source/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L761

	usbss0: cdns-usb@...0000 {
		compatible = "ti,am64-usb";
		reg = <0x00 0xf900000 0x00 0x100>;

> Due to this, it gives an error as in the YAML file the order is in
> reverse order.
> Also, I cloned the repo yesterday and still found the same error in
> the dtsi file.
> So have I done something wrong? as I see I might be out of sync with
> latest changes

You seem to be looking at some old tree. Please refer to latest kernel
tree when submitting changes upstream.

-- 
cheers,
-roger