[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4b7a8888-e43d-4a90-bcf1-a09c83117d4b@kernel.org>
Date: Sat, 28 Sep 2024 10:21:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>,
"Rob Herring (Arm)" <robh@...nel.org>
Cc: Matthias Brugger <mbrugger@...e.com>, NXP S32 Linux Team <s32@....com>,
Chester Lin <chester62515@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>,
devicetree@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-arm-kernel@...ts.infradead.org, Conor Dooley <conor+dt@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, Christophe Lizzi
<clizzi@...hat.com>, Alberto Ruiz <aruizrui@...hat.com>,
Enric Balletbo <eballetb@...hat.com>, linux-gpio@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3
SoCs
On 27/09/2024 09:19, Andrei Stefanescu wrote:
> Hi,
>
> On 26/09/2024 20:43, Rob Herring (Arm) wrote:
>>
>> On Thu, 26 Sep 2024 17:31:19 +0300, Andrei Stefanescu wrote:
>>> Add support for the GPIO driver of the NXP S32G2/S32G3 SoCs.
>>>
>>> Signed-off-by: Phu Luu An <phu.luuan@....com>
>>> Signed-off-by: Larisa Grigore <larisa.grigore@....com>
>>> Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@....com>
>>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
>>> ---
>>> .../bindings/gpio/nxp,s32g2-siul2-gpio.yaml | 110 ++++++++++++++++++
>>> 1 file changed, 110 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.yaml
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>> ./Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> I don't get this error locally:
Really?
The code is clearly not correct, wrong indentation, so if you do not see
the error, then something in your setup needs to be fixed.
>
> $ make DT_SCHEMA_FILES=nxp,s32g2-siul2-gpio.yaml dt_binding_check
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> CHKDT Documentation/devicetree/bindings
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.example.dts
> DTC [C] Documentation/devicetree/bindings/gpio/nxp,s32g2-siul2-gpio.example.dtb
>
> $ pip3 show dtschema
> Name: dtschema
> Version: 2024.9
>
> $ yamllint --version
> yamllint 1.35.1
>
>
> Lines around 25:
>
> 20 properties:
> 21 compatible:
> 22 oneOf:
> 23 - description: for S32G2 SoCs
> 24 items:
> 25 - const: nxp,s32g2-siul2-gpio
> 26 - description: for S32G3 SoCs
> 27 items:
> 28 - const: nxp,s32g3-siul2-gpio
> 29 - const: nxp,s32g2-siul2-gpio
>
> I initially had the reported error but I fixed it locally by adding the following:
I don't understand. So you had the error, but you fixed it, but you sent
wrong patch with the error?
This is just confusing. Re-apply this patch (b4 shazam) and test it
again. Please keep testing till you see the error, so you know your
environment works properly.
Best regards,
Krzysztof
Powered by blists - more mailing lists