linux-kernel - Re: [PATCH v7 13/26] rust: alloc: implement kernel `Vec` type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d71296c-e605-47cb-a8be-8cd16c54d9d4@proton.me>
Date: Sat, 28 Sep 2024 13:20:45 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Danilo Krummrich <dakr@...nel.org>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, a.hindborg@...sung.com, aliceryhl@...gle.com, akpm@...ux-foundation.org, daniel.almeida@...labora.com, faith.ekstrand@...labora.com, boris.brezillon@...labora.com, lina@...hilina.net, mcanal@...lia.com, zhiw@...dia.com, cjia@...dia.com, jhubbard@...dia.com, airlied@...hat.com, ajanulgu@...hat.com, lyude@...hat.com, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v7 13/26] rust: alloc: implement kernel `Vec` type

On 28.09.24 14:43, Danilo Krummrich wrote:
> On Thu, Sep 26, 2024 at 01:47:04PM +0000, Benno Lossin wrote:
>> On 12.09.24 00:52, Danilo Krummrich wrote:
>>> +    /// Appends an element to the back of the [`Vec`] instance.
>>> +    ///
>>> +    /// # Examples
>>> +    ///
>>> +    /// ```
>>> +    /// let mut v = KVec::new();
>>> +    /// v.push(1, GFP_KERNEL)?;
>>> +    /// assert_eq!(&v, &[1]);
>>> +    ///
>>> +    /// v.push(2, GFP_KERNEL)?;
>>> +    /// assert_eq!(&v, &[1, 2]);
>>> +    /// # Ok::<(), Error>(())
>>> +    /// ```
>>> +    pub fn push(&mut self, v: T, flags: Flags) -> Result<(), AllocError> {
>>> +        Vec::reserve(self, 1, flags)?;
>>> +
>>> +        // SAFETY:
>>> +        // - `self.len` is smaller than `self.capacity` and hence, the resulting pointer is
>>> +        //   guaranteed to be part of the same allocated object.
>>> +        // - `self.len` can not overflow `isize`.
>>> +        let ptr = unsafe { self.as_mut_ptr().add(self.len) };
>>> +
>>> +        // SAFETY:
>>> +        // - `ptr` is properly aligned and valid for writes.
>>> +        unsafe { core::ptr::write(ptr, v) };
>>
>> Why not use `self.spare_capacity_mut()[0].write(v);`?
> 
> Before v7 I did exactly that, but in v6 you suggested to use the raw pointer
> instead to avoid the bounds check.

Ah I see... Would be pretty useful for me to have my previous comments
easily accessible, I don't usually look at the previous thread. Is
anyone aware of some tools for that?

>> If you want to avoid the bounds check, you can do
>>
>>     let first = self.spare_capacity_mut().first();
>>     // SAFETY: the call to `Vec::reserve` above ensures that `spare_capacity_mut()` is non-empty.
>>     unsafe { first.unwrap_unchecked() }.write(v);
> 
> `first` does a similar check to create the `Option<&T>`, right?. I'd rather keep
> the raw pointer access as suggested in v6.

It does a check, but the optimizer will get rid of it if you use
`unwrap_unchecked` [1]. But feel free to leave it as-is.

[1]: https://godbolt.org/z/zYbMTo86M

---
Cheers,
Benno