linux-kernel - Re: [PATCH v5 3/3] drivers: iio: adc: add support for ad777x family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240928153109.52ff4c5e@jic23-huawei>
Date: Sat, 28 Sep 2024 15:31:09 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: "Nechita, Ramona" <Ramona.Nechita@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, "Tanislav, Cosmin"
 <Cosmin.Tanislav@...log.com>, "Hennerich, Michael"
 <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, "Sa,
 Nuno" <Nuno.Sa@...log.com>, Andy Shevchenko <andy@...nel.org>, David
 Lechner <dlechner@...libre.com>, "Schmitt, Marcelo"
 <Marcelo.Schmitt@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>,
 Dumitru Ceclan <mitrutzceclan@...il.com>, Matteo Martelli
 <matteomartelli3@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Alisa-Dariana Roman
 <alisadariana@...il.com>, Ivan Mikhaylov <fr0st61te@...il.com>, Mike
 Looijmans <mike.looijmans@...ic.nl>, "linux-iio@...r.kernel.org"
 <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 3/3] drivers: iio: adc: add support for ad777x family


> >> +
> >> +	ret = ad7779_reset(indio_dev, reset_gpio);
> >> +	if (ret)
> >> +		return ret;
> >> +
> >> +	ad7779_powerup(st, start_gpio);
> >> +	if (ret)
> >> +		return ret;  
> >What powers the device down again if we hit an error?
> >
> >Probably need a devm_add_action_or_reset() or if it self powers down may a comment on that.  
> 
> In the powerup function there are only some register writes and the start gpio is only a synchronization pulse (perhaps the name powerup is not very appropriate), 
> would an action or reset be necessary in this case? Since the regulators are not used in the driver, should there be a function disabling them anyway?
> 
If there is nothing useful to do indeed not but when I see
a power up, I rather expect a power down.  Is there anything
that can do that or is it a case of it will go to sleep anyway
for some other reason?

Jonathan

> 
> Best Regards,
> Ramona
>