linux-kernel - Re: [PATCH v8 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <316e200d-74b6-4d03-952e-e8612276f0e8@wanadoo.fr>
Date: Sat, 28 Sep 2024 18:56:40 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Farouk Bouabid <farouk.bouabid@...rry.de>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Quentin Schulz <quentin.schulz@...rry.de>,
 Peter Rosin <peda@...ntia.se>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, Heiko Stuebner <heiko@...ech.de>
Cc: linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH v8 2/8] i2c: muxes: add support for tsd,mule-i2c
 multiplexer

Le 06/09/2024 à 17:54, Farouk Bouabid a écrit :
> Theobroma Systems Mule is an MCU that emulates a set of I2C devices,
> among which an amc6821 and devices that are reachable through an I2C-mux.
> The devices on the mux can be selected by writing the appropriate device
> number to an I2C config register (amc6821 reg 0xff).
> 
> This driver is expected to be probed as a platform device with amc6821
> as its parent i2c device.
> 
> Add support for the mule-i2c-mux platform driver. The amc6821 driver
> support for the mux will be added in a later commit.
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Signed-off-by: Farouk Bouabid <farouk.bouabid@...rry.de>
> ---

Hi,

> +static const struct of_device_id mule_i2c_mux_of_match[] = {
> +	{ .compatible = "tsd,mule-i2c-mux", },
> +	{},

Nitpick (in case of v9): usually, a comma is not added after a terminator.

> +};

...