linux-kernel - [PATCH 0/8] cifs: Fix support for NFS-style reparse points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240928215948.4494-1-pali@kernel.org>
Date: Sat, 28 Sep 2024 23:59:40 +0200
From: Pali Rohár <pali@...nel.org>
To: Steve French <sfrench@...ba.org>,
	Paulo Alcantara <pc@...guebit.com>,
	Ronnie Sahlberg <ronniesahlberg@...il.com>
Cc: linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/8] cifs: Fix support for NFS-style reparse points

For NFS-style reparse points in the current Linux SMB client I found few
buffer overflows and then incompatibility issues related to char/block
devices and symlinks. In this patch series I'm addressing these issues.
I also located commits which introduced these issues, I put them into
Fixes lines of commit messages.

Test cases against Windows server which exports one directory over both
SMB and NFS protocols. On Linux is mounted that directory to /mnt/nfs
and /mnt/smb via different protocols.

  mknod /mnt/nfs/char c 1 3
  stat /mnt/smb/char
  mknod /mnt/nfs/block b 8 0
  stat /mnt/smb/block
  ln -s abc\\abc /mnt/nfs/symlink
  stat /mnt/smb/symlink
  ls -l /mnt/smb

ls -l or stat over SMB should show the same information about char, block
and symlink as over NFS. And vice-versa.

Please look and check the buffer overflow issue as these buffer lengths
are always nightmares to handle correctly.

Pali Rohár (8):
  smb: Update comments about some reparse point tags
  cifs: Remove intermediate object of failed create reparse call
  cifs: Fix parsing NFS-style char/block devices
  cifs: Fix creating NFS-style char/block devices
  cifs: Fix buffer overflow when parsing NFS reparse points
  cifs: Do not convert delimiter when parsing NFS-style symlinks
  cifs: Validate content of NFS reparse point buffer
  cifs: Rename posix to nfs in parse_reparse_posix() and
    reparse_posix_data

 fs/smb/client/cifsglob.h  |  2 +-
 fs/smb/client/cifspdu.h   |  2 +-
 fs/smb/client/reparse.c   | 53 +++++++++++++++++++++++++++++++--------
 fs/smb/client/reparse.h   | 12 ++++++---
 fs/smb/client/smb2inode.c | 21 ++++++++++++++--
 fs/smb/common/smb2pdu.h   |  2 +-
 fs/smb/common/smbfsctl.h  |  7 +++---
 7 files changed, 77 insertions(+), 22 deletions(-)

-- 
2.20.1