lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list] 
Message-ID: <202409281015.ZcDlYBGw-lkp@intel.com>
Date: Sat, 28 Sep 2024 11:14:15 +0800
From: kernel test robot <lkp@...el.com>
To: Ricardo Ribalda <ribalda@...omium.org>, Benoit Parrot <bparrot@...com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Bingbu Cao <bingbu.cao@...el.com>,
	Tianshu Qiu <tian.shu.qiu@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Andy Shevchenko <andy@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev,
	Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH v2 1/3] media: ti: cal: Use str_up_down()

Hi Ricardo,

kernel test robot noticed the following build errors:

[auto build test ERROR on 075dbe9f6e3c21596c5245826a4ee1f1c1676eb8]

url:    https://github.com/intel-lab-lkp/linux/commits/Ricardo-Ribalda/media-ti-cal-Use-str_up_down/20240927-180438
base:   075dbe9f6e3c21596c5245826a4ee1f1c1676eb8
patch link:    https://lore.kernel.org/r/20240927-cocci-6-12-v2-1-1c6ad931959b%40chromium.org
patch subject: [PATCH v2 1/3] media: ti: cal: Use str_up_down()
config: i386-buildonly-randconfig-003-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281015.ZcDlYBGw-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409281015.ZcDlYBGw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409281015.ZcDlYBGw-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/media/platform/ti/cal/cal-camerarx.c:193:3: error: unterminated function-like macro invocation
     193 |                 phy_err(phy, "Failed to power %s complexio\n",
         |                 ^
   drivers/media/platform/ti/cal/cal.h:278:9: note: macro 'phy_err' defined here
     278 | #define phy_err(phy, fmt, arg...)                                       \
         |         ^
>> drivers/media/platform/ti/cal/cal-camerarx.c:897:2: error: expected expression
     897 | }
         |  ^
>> drivers/media/platform/ti/cal/cal-camerarx.c:897:2: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
   drivers/media/platform/ti/cal/cal-camerarx.c:192:2: note: previous statement is here
     192 |         if (i == 10)
         |         ^
>> drivers/media/platform/ti/cal/cal-camerarx.c:897:2: error: expected '}'
     897 | }
         |  ^
   drivers/media/platform/ti/cal/cal-camerarx.c:169:1: note: to match this '{'
     169 | {
         | ^
   1 warning and 3 errors generated.


vim +193 drivers/media/platform/ti/cal/cal-camerarx.c

af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  167  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  168  static void cal_camerarx_power(struct cal_camerarx *phy, bool enable)
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  169  {
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  170  	u32 target_state;
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  171  	unsigned int i;
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  172  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  173  	target_state = enable ? CAL_CSI2_COMPLEXIO_CFG_PWR_CMD_STATE_ON :
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  174  		       CAL_CSI2_COMPLEXIO_CFG_PWR_CMD_STATE_OFF;
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  175  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  176  	cal_write_field(phy->cal, CAL_CSI2_COMPLEXIO_CFG(phy->instance),
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  177  			target_state, CAL_CSI2_COMPLEXIO_CFG_PWR_CMD_MASK);
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  178  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  179  	for (i = 0; i < 10; i++) {
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  180  		u32 current_state;
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  181  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  182  		current_state = cal_read_field(phy->cal,
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  183  					       CAL_CSI2_COMPLEXIO_CFG(phy->instance),
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  184  					       CAL_CSI2_COMPLEXIO_CFG_PWR_STATUS_MASK);
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  185  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  186  		if (current_state == target_state)
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  187  			break;
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  188  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  189  		usleep_range(1000, 1100);
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  190  	}
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  191  
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  192  	if (i == 10)
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06 @193  		phy_err(phy, "Failed to power %s complexio\n",
368e80f16a6aff drivers/media/platform/ti/cal/cal-camerarx.c Ricardo Ribalda  2024-09-27  194  			str_up_down(enable);
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  195  }
af30d4f36ef35d drivers/media/platform/ti-vpe/cal-camerarx.c Laurent Pinchart 2020-07-06  196  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ