linux-kernel - Re: [PATCH v3 07/14] scsi: fnic: Add and integrate support for FIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409291955.FcMZfNSt-lkp@intel.com>
Date: Sun, 29 Sep 2024 19:39:02 +0800
From: kernel test robot <lkp@...el.com>
To: Karan Tilak Kumar <kartilak@...co.com>, sebaddel@...co.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, arulponn@...co.com,
	djhawar@...co.com, gcboffa@...co.com, mkai2@...co.com,
	satishkh@...co.com, aeasi@...co.com, jejb@...ux.ibm.com,
	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Karan Tilak Kumar <kartilak@...co.com>
Subject: Re: [PATCH v3 07/14] scsi: fnic: Add and integrate support for FIP

Hi Karan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.11 next-20240927]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Karan-Tilak-Kumar/scsi-fnic-Replace-shost_printk-with-dev_info-dev_err/20240928-025906
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20240927184613.52172-8-kartilak%40cisco.com
patch subject: [PATCH v3 07/14] scsi: fnic: Add and integrate support for FIP
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240929/202409291955.FcMZfNSt-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240929/202409291955.FcMZfNSt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409291955.FcMZfNSt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/fnic/fnic_fcs.c:292:21: warning: variable 'fnic_stats' set but not used [-Wunused-but-set-variable]
     292 |         struct fnic_stats *fnic_stats;
         |                            ^
   1 warning generated.


vim +/fnic_stats +292 drivers/scsi/fnic/fnic_fcs.c

   289	
   290	void fnic_handle_fip_frame(struct work_struct *work)
   291	{
 > 292		struct fnic_stats *fnic_stats;
   293		struct fnic_frame_list *cur_frame, *next;
   294		struct fnic *fnic = container_of(work, struct fnic, fip_frame_work);
   295	
   296		fnic_stats = &fnic->fnic_stats;
   297		FNIC_FCS_DBG(KERN_INFO, fnic->lport->host, fnic->fnic_num,
   298					 "Processing FIP frame\n");
   299	
   300		spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);
   301		list_for_each_entry_safe(cur_frame, next, &fnic->fip_frame_queue,
   302								 links) {
   303			if (fnic->stop_rx_link_events) {
   304				list_del(&cur_frame->links);
   305				spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
   306				kfree(cur_frame->fp);
   307				kfree(cur_frame);
   308				return;
   309			}
   310	
   311			/*
   312			 * If we're in a transitional state, just re-queue and return.
   313			 * The queue will be serviced when we get to a stable state.
   314			 */
   315			if (fnic->state != FNIC_IN_FC_MODE &&
   316				fnic->state != FNIC_IN_ETH_MODE) {
   317				spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
   318				return;
   319			}
   320	
   321			list_del(&cur_frame->links);
   322	
   323			if (fdls_fip_recv_frame(fnic, cur_frame->fp)) {
   324				kfree(cur_frame->fp);
   325				kfree(cur_frame);
   326			}
   327		}
   328		spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
   329	}
   330	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki