linux-kernel - Re: [PATCH v1 02/11] perf build: Remove defined but never used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240929110225.70061347465502e318c5567b@kernel.org>
Date: Sun, 29 Sep 2024 11:02:25 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim
 <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander
 Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa
 <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
 <kan.liang@...ux.intel.com>, John Garry <john.g.garry@...cle.com>, Will
 Deacon <will@...nel.org>, James Clark <james.clark@...aro.org>, Mike Leach
 <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>, Guo Ren
 <guoren@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer
 Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Nick
 Terrell <terrelln@...com>, Guilherme Amadio <amadio@...too.org>, Changbin
 Du <changbin.du@...wei.com>, "Steinar H. Gunderson" <sesse@...gle.com>,
 Aditya Gupta <adityag@...ux.ibm.com>, Athira Rajeev
 <atrajeev@...ux.vnet.ibm.com>, Masahiro Yamada <masahiroy@...nel.org>,
 Huacai Chen <chenhuacai@...nel.org>, Bibo Mao <maobibo@...ngson.cn>, Kajol
 Jain <kjain@...ux.ibm.com>, Anup Patel <anup@...infault.org>, Shenlin Liang
 <liangshenlin@...incomputing.com>, Atish Patra <atishp@...osinc.com>,
 Oliver Upton <oliver.upton@...ux.dev>, Chen Pei <cp0613@...ux.alibaba.com>,
 Dima Kogan <dima@...retsauce.net>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org, Yang Jihong
 <yangjihong@...edance.com>
Subject: Re: [PATCH v1 02/11] perf build: Remove defined but never used
 variable

On Tue, 24 Sep 2024 09:04:09 -0700
Ian Rogers <irogers@...gle.com> wrote:

> Previously NO_DWARF_UNWIND was part of conditional compilation but it
> is now unused so remove.
> 

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thank you!

> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/Makefile.config | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 55a39211496d..182e14e39cd5 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -753,8 +753,6 @@ endif
>  ifeq ($(dwarf-post-unwind),1)
>    CFLAGS += -DHAVE_DWARF_UNWIND_SUPPORT
>    $(call detected,CONFIG_DWARF_UNWIND)
> -else
> -  NO_DWARF_UNWIND := 1
>  endif
>  
>  ifndef NO_LOCAL_LIBUNWIND
> -- 
> 2.46.0.792.g87dc391469-goog
> 

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>