linux-kernel - Re: [PATCH] uprobes: fix kernel info leak via "[uprobes]" vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240930003931.f1927079bf6feccb6627416e@kernel.org>
Date: Mon, 30 Sep 2024 00:39:31 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Catalin Marinas
 <catalin.marinas@....com>, "Liao, Chang" <liaochang1@...wei.com>, Will
 Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uprobes: fix kernel info leak via "[uprobes]" vma

On Sun, 29 Sep 2024 16:50:00 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> On 09/29, Masami Hiramatsu wrote:
> >
> > On Thu, 26 Sep 2024 18:29:01 +0200
> > Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > > xol_add_vma() maps the uninitialized page allocated by __create_xol_area()
> > > into userspace. On some architectures (x86) this memory is readable even
> > > without VM_READ, VM_EXEC results in the same pgprot_t as VM_EXEC|VM_READ.
> >
> > Good catch!
> > I think we push this urgently and send it to stable tree too, right?
> 
> Agreed, can you route this patch?

Yeah, OK.

> 
> > Fixes: d4b3b6384f98 ("uprobes/core: Allocate XOL slots for uprobes use")
> > Cc: stable@...r.kernel.org
> 
> Will add this or should I resend with these tags included ?

No, but can you confirm this is correct tag? I just track when the
alloc_page() came from.

> 
> perhaps the changelog should mention that debugger can read this memory
> regardless of pgprot_t...

OK, if you can do that, can you add it and resend it?

Thank you,

> 
> > Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Thanks!
> 
> Oleg.
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>