linux-kernel - Re: [External] [PATCH -next] perf test: Use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a5f0b71-2478-456e-bf4f-5132fb4f255d@bytedance.com>
Date: Sun, 29 Sep 2024 10:24:43 +0800
From: Yang Jihong <yangjihong@...edance.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, peterz@...radead.org,
 mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
 mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
 irogers@...gle.com, adrian.hunter@...el.com, kan.liang@...ux.intel.com
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [External] [PATCH -next] perf test: Use ARRAY_SIZE for array
 length

Hello,

On 9/27/24 16:40, Jiapeng Chong wrote:
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> 
> ./tools/perf/tests/demangle-java-test.c:31:34-35: WARNING: Use ARRAY_SIZE.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11173
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   tools/perf/tests/demangle-java-test.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/demangle-java-test.c b/tools/perf/tests/demangle-java-test.c
> index 44d1be303b67..611c18cdf4d3 100644
> --- a/tools/perf/tests/demangle-java-test.c
> +++ b/tools/perf/tests/demangle-java-test.c
> @@ -6,6 +6,7 @@
>   #include "session.h"
>   #include "debug.h"
>   #include "demangle-java.h"
> +#include "kselftest.h"

The wrong header file is included here, causing the build to fail:

   CC      tests/demangle-java-test.o
tests/demangle-java-test.c:9:10: fatal error: kselftest.h: No such file 
or directory
     9 | #include "kselftest.h"
       |          ^~~~~~~~~~


The correct header file to include should be: <linux/kernel.h>

Thanks,
Yang

>   
>   static int test__demangle_java(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
>   {
> @@ -28,7 +29,7 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte
>   		  "void java.lang.Object<init>()" },
>   	};
>   
> -	for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
> +	for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
>   		buf = java_demangle_sym(test_cases[i].mangled, 0);
>   		if (strcmp(buf, test_cases[i].demangled)) {
>   			pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,