linux-kernel - RE: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5678B708831B5EEACA1E5A31C9752@SJ0PR11MB5678.namprd11.prod.outlook.com>
Date: Sun, 29 Sep 2024 21:04:57 +0000
From: "Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
To: Nhat Pham <nphamcs@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "hannes@...xchg.org"
	<hannes@...xchg.org>, "yosryahmed@...gle.com" <yosryahmed@...gle.com>,
	"chengming.zhou@...ux.dev" <chengming.zhou@...ux.dev>,
	"usamaarif642@...il.com" <usamaarif642@...il.com>, "shakeel.butt@...ux.dev"
	<shakeel.butt@...ux.dev>, "ryan.roberts@....com" <ryan.roberts@....com>,
	"Huang, Ying" <ying.huang@...el.com>, "21cnbao@...il.com"
	<21cnbao@...il.com>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"Zou, Nanhai" <nanhai.zou@...el.com>, "Feghali, Wajdi K"
	<wajdi.k.feghali@...el.com>, "Gopal, Vinodh" <vinodh.gopal@...el.com>,
	"Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
Subject: RE: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to
 zswap_pool_tryget().

> -----Original Message-----
> From: Nhat Pham <nphamcs@...il.com>
> Sent: Saturday, September 28, 2024 4:27 PM
> To: Sridhar, Kanchana P <kanchana.p.sridhar@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-mm@...ck.org;
> hannes@...xchg.org; yosryahmed@...gle.com;
> chengming.zhou@...ux.dev; usamaarif642@...il.com;
> shakeel.butt@...ux.dev; ryan.roberts@....com; Huang, Ying
> <ying.huang@...el.com>; 21cnbao@...il.com; akpm@...ux-foundation.org;
> Zou, Nanhai <nanhai.zou@...el.com>; Feghali, Wajdi K
> <wajdi.k.feghali@...el.com>; Gopal, Vinodh <vinodh.gopal@...el.com>
> Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to
> zswap_pool_tryget().
> 
> On Fri, Sep 27, 2024 at 7:16 PM Kanchana P Sridhar
> <kanchana.p.sridhar@...el.com> wrote:
> >
> > Modify the name of the existing zswap_pool_get() to zswap_pool_tryget()
> > to be representative of the call it makes to percpu_ref_tryget().
> > A subsequent patch will introduce a new zswap_pool_get() that calls
> > percpu_ref_get().
> >
> > The intent behind this change is for higher level zswap API such as
> > zswap_store() to call zswap_pool_tryget() to check upfront if the pool's
> > refcount is "0" (which means it could be getting destroyed) and to handle
> > this as an error condition. zswap_store() would proceed only if
> > zswap_pool_tryget() returns success, and any additional pool refcounts that
> > need to be obtained for compressing sub-pages in a large folio could simply
> > call zswap_pool_get().
> >
> > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
> 
> Reviewed-by: Nhat Pham <nphamcs@...il.com>

Thanks Nhat! 

Thanks,
Kanchana