linux-kernel - [PATCH] drm/panthor: Set FMODE_UNSIGNED_OFFSET in fop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240929221034.1889572-1-linkmauve@linkmauve.fr>
Date: Mon, 30 Sep 2024 00:10:31 +0200
From: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
To: 
Cc: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
	Christian Brauner <brauner@...nel.org>,
	Jeff Layton <jlayton@...nel.org>,
	Jan Kara <jack@...e.cz>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Steven Price <steven.price@....com>,
	Liviu Dudau <liviu.dudau@....com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] drm/panthor: Set FMODE_UNSIGNED_OFFSET in fop_flags

This fixes a regression introduced in commit
641bb4394f405cba498b100b44541ffc0aed5be1.  No panthor device, card or
render node, could be open() since this commit, returning EINVAL
instead.  This prevented Mesa from working on SoCs such as the rk3588
which contains a Mali-G610 GPU.

The commit mentions which drivers must be changed to set that flag, but
panthor seemingly got forgotten, triggering the WARN_ON_ONCE() added
in drm_open_helper().
---
 drivers/gpu/drm/panthor/panthor_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 34182f67136c..c520f156e2d7 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
 	.read = drm_read,
 	.llseek = noop_llseek,
 	.mmap = panthor_mmap,
+	.fop_flags = FOP_UNSIGNED_OFFSET,
 };
 
 #ifdef CONFIG_DEBUG_FS
-- 
2.46.2