linux-kernel - Re: [PATCH 2/3] dt-bindings: pinctrl: add S32G3 compatible for the SIUL2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <431dd907-026b-4215-96ef-28fdeb2b43a2@oss.nxp.com>
Date: Mon, 30 Sep 2024 17:46:09 +0300
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dong Aisheng
 <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>,
 Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Ghennadi Procopciuc
 <Ghennadi.Procopciuc@....nxp.com>, Chester Lin <chester62515@...il.com>,
 Matthias Brugger <mbrugger@...e.com>, Sascha Hauer <s.hauer@...gutronix.de>
Cc: Pengutronix Kernel Team <kernel@...gutronix.de>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 imx@...ts.linux.dev, NXP S32 Linux Team <s32@....com>,
 Christophe Lizzi <clizzi@...hat.com>, Alberto Ruiz <aruizrui@...hat.com>,
 Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH 2/3] dt-bindings: pinctrl: add S32G3 compatible for the
 SIUL2 driver

Hi Krzysztof,

Thank you for the quick review!

On 30/09/2024 16:40, Krzysztof Kozlowski wrote:
> On 30/09/2024 15:23, Andrei Stefanescu wrote:
>> The SIUL2 hardware module is also integrated into the S32G3 SoC. Add
>> another compatible for it.
>>
>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
>> ---
>>  .../bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml      | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml
>> index a24286e4def6..454773e7aa07 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml
>> @@ -25,8 +25,14 @@ description: |
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - nxp,s32g2-siul2-pinctrl
>> +    oneOf:
>> +      - description: for S32G2 SoCs
> 
> Drop
> 
>> +        items:
> 
> That's jus tenum
> 
>> +          - const: nxp,s32g2-siul2-pinctrl
> 
> Drop
> 
>> +      - description: for S32G3 SoCs
>> +        items:

Just to make sure I understood correctly, it should
look something like this, right?

    oneOf:
      - enum:
          - const: nxp,s32g2-siul2-pinctrl
      - items:
          - const: nxp,s32g3-siul2-pinctrl
          - const: nxp,s32g2-siul2-pinctrl


> Best regards,
> Krzysztof
> 

Best regards,
Andrei