lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <A9EB783B-50AA-4C9B-BDF8-A9E7B8CC7BFA@gmail.com>
Date: Mon, 30 Sep 2024 16:47:50 +0200
From: Denis Benato <benato.denis96@...il.com>
To: Lars-Peter Clausen <lars@...afoo.de>, David Binderman <dcb314@...mail.com>,
 "jagathjog1996@...il.com" <jagathjog1996@...il.com>,
 "jic23@...nel.org" <jic23@...nel.org>,
 "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-6.12-rc1/drivers/iio/imu/bmi323/bmi323_core.c:133: Array contents defined but not used ?



Il 30 settembre 2024 16:19:14 CEST, Lars-Peter Clausen <lars@...afoo.de> ha scritto:
>On 9/30/24 06:49, David Binderman wrote:
>> Hello there,
>> 
>> I just tried to build linux-6.12-rc1 with clang. It said:
>> 
>> drivers/iio/imu/bmi323/bmi323_core.c:133:27: warning: variable 'bmi323_ext_reg_savestate' is not needed and will not be emitted [-Wunneeded-internal-declaration]
>> 
>> A grep for the identifier shows the following strange results::
>> 
>> inux-6.12-rc1 $ grep bmi323_ext_reg_savestate drivers/iio/imu/bmi323/bmi323_core.c
>> static const unsigned int bmi323_ext_reg_savestate[] = {
>> 	unsigned int ext_reg_settings[ARRAY_SIZE(bmi323_ext_reg_savestate)];
>> 	for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
>> 	for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
>> linux-6.12-rc1 $
>> 
>> I see no mention of bmi323_ext_reg_savestate[ i]. Is there a possible
>> cut'n'paste error in one of the two for loops ?
>Yes. Do you want to send a fix?
>
Hello,

I think fixes are pending already in one of Jonathan Cameron's branches.

Best regards,
Denis Benato

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ