linux-kernel - Re: [PATCH] rust: re-order exports to fix rustfmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvoyeO8pUJBwkYEM@redaops>
Date: Mon, 30 Sep 2024 08:09:12 +0300
From: Tudor Gheorghiu <tudor.reda@...il.com>
To: Dirk Behme <dirk.behme@...bosch.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: re-order exports to fix rustfmt

On Mon, Sep 30, 2024 at 06:15:32AM +0200, Dirk Behme wrote:
> On 30.09.2024 03:09, Tudor Gheorghiu wrote:
> > In the recent rust-6.12 tag merge at 570172569238, the rbtree export was
> > added after the sizes export, thus breaking rustfmt's alphabetical
> > export ordering rules.
> > 
> > Signed-off-by: Tudor Gheorghiu <tudor.reda@...il.com>
> > ---
> >   rust/kernel/lib.rs | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> > index 22a3bfa5a9e9..b5f4b3ce6b48 100644
> > --- a/rust/kernel/lib.rs
> > +++ b/rust/kernel/lib.rs
> > @@ -44,8 +44,8 @@
> >   pub mod page;
> >   pub mod prelude;
> >   pub mod print;
> > -pub mod sizes;
> >   pub mod rbtree;
> > +pub mod sizes;
> >   mod static_assert;
> >   #[doc(hidden)]
> 
> I think we have that in rust-fixes already:
> 
> https://github.com/Rust-for-Linux/linux/commit/ece207a83e464af710d641f29e32b7a144c48e79
> 
> Dirk
> 

You are correct! I didn't check rust-fixes, as I was working on
something else when I noticed this.

Thanks!

Have a great day!
Tudor