linux-kernel - Re: [PATCH 21/35] ring-buffer: Reorganize kerneldoc parameter names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240930111431.258b72d1@gandalf.local.home>
Date: Mon, 30 Sep 2024 11:14:31 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: kernel-janitors@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 21/35] ring-buffer: Reorganize kerneldoc parameter names

On Mon, 30 Sep 2024 13:21:07 +0200
Julia Lawall <Julia.Lawall@...ia.fr> wrote:

> Reorganize kerneldoc parameter names to match the parameter
> order in the function header.
> 
> Problems identified using Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> 
> ---
>  kernel/trace/ring_buffer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 77dc0b25140e..313dffbdeef1 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -2384,9 +2384,9 @@ EXPORT_SYMBOL_GPL(__ring_buffer_alloc);
>   * __ring_buffer_alloc_range - allocate a new ring_buffer from existing memory
>   * @size: the size in bytes per cpu that is needed.
>   * @flags: attributes to set for the ring buffer.
> + * @order: sub-buffer order
>   * @start: start of allocated range
>   * @range_size: size of allocated range
> - * @order: sub-buffer order
>   * @key: ring buffer reader_lock_key.
>   *
>   * Currently the only flag that is available is the RB_FL_OVERWRITE