linux-kernel - Re: [PATCH v4 00/11] i3c: master: some fix and improvemnt for hotjoin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvrAuOBLgi+HtrPD@lizhi-Precision-Tower-5810>
Date: Mon, 30 Sep 2024 11:16:08 -0400
From: Frank Li <Frank.li@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Parshuram Thombare <pthombar@...ence.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Conor Culhane <conor.culhane@...vaco.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev,
	Ravindra Yashvant Shinde <ravindra.yashvant.shinde@....com>,
	stable@...nel.org
Subject: Re: [PATCH v4 00/11] i3c: master: some fix and improvemnt for hotjoin

On Mon, Sep 30, 2024 at 11:34:36AM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.li@....com wrote on Thu, 26 Sep 2024 13:02:06 -0400:
>
> > On Thu, Aug 29, 2024 at 05:13:57PM -0400, Frank Li wrote:
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> >
> > Alex:
> >
> > https://lore.kernel.org/linux-i3c/20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com/T/#m16fa9bb875b0ae9d37c5f6e91f90e375551c6366
> >
> > There is some discuss about assiged address, I already explain the reason
> > and ping 3 times,
>
> Pinging will not help as long as the code is not clear and simplified.

The problem is that no reply after I posted last reply and ping 3 times
have not response about it.

> I honestly think the PID should be retrieved earlier in the HCI part
> and that would solve most of your issues.

If there are problem or difference opinion, we can continue to discuss it.
But no reply will stop the whole thing move forward.

I3C HCI Spec 1.2, sec 6.4.1, when do DAA,  "DAA CMD and dynmatic address"
queue to cmd together.  We don't know PID before DAA CMD. So dynmatic
address can NOT get based on PID.

If I am wrong about HCI, let me know since I have not worked HCI before.

>
> Otherwise if that is not possible I still find hard to understand the
> big picture, the comments and the code. I've already spent quite a bit
> of time trying to improve it with you, but the logic is still a little
> bit too specific and complex from my point of view.
>
> > These patch are actual fixed hot join issues.
>
> It should not be the case. Hot-join should work without the devices
> having all the time the preferred address. If hot-join really does
> not work, then please split the series with the "preferred address"
> handling being done apart in a second series.

I can do that, could you check svc part and most already acked you? I can
post svc part only later by addressing your comments if you have.

Frank

>
> Thanks,
> Miquèl