[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240930155459.GE1310185@kernel.org>
Date: Mon, 30 Sep 2024 16:54:59 +0100
From: Simon Horman <horms@...nel.org>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
decui@...rosoft.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com,
shradhagupta@...ux.microsoft.com, leon@...nel.org,
colin.i.king@...il.com, ahmed.zaki@...el.com,
linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: mana: Add get_link and
get_link_ksettings in ethtool
On Sun, Sep 29, 2024 at 10:42:14PM -0700, Erni Sri Satya Vennela wrote:
> Add support for the ethtool get_link and get_link_ksettings
> operations. Display standard port information using ethtool.
>
> Before the change:
> $ethtool enP30832s1
> > No data available
>
> After the change:
> $ethtool enP30832s1
> > Settings for enP30832s1:
> Supported ports: [ ]
> Supported link modes: Not reported
> Supported pause frame use: No
> Supports auto-negotiation: No
> Supported FEC modes: Not reported
> Advertised link modes: Not reported
> Advertised pause frame use: No
> Advertised auto-negotiation: No
> Advertised FEC modes: Not reported
> Speed: Unknown!
> Duplex: Full
> Auto-negotiation: off
> Port: Other
> PHYAD: 0
> Transceiver: internal
> Link detected: yes
>
> Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> ---
> Changes in v2:
> * Remove support for displaying auto-negotiation details
> * Change PORT_DA to PORT_OTHER
Thanks, this version looks good to me.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists