linux-kernel - Re: [PATCH 07/14] x86/ibt: Clean up is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQLbZRJyoF8yBZV3nnm8yQVeevQW0=stYv0HXBmZpY2BJw@mail.gmail.com>
Date: Mon, 30 Sep 2024 09:43:06 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Andrii Nakryiko <andrii@...nel.org>, Jiri Olsa <jolsa@...nel.org>, X86 ML <x86@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, alyssa.milburn@...el.com, 
	scott.d.constable@...el.com, Joao Moreira <joao@...rdrivepizza.com>, 
	Andrew Cooper <andrew.cooper3@...rix.com>, Josh Poimboeuf <jpoimboe@...nel.org>, 
	"Jose E. Marchesi" <jose.marchesi@...cle.com>, "H.J. Lu" <hjl.tools@...il.com>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Nathan Chancellor <nathan@...nel.org>, ojeda@...nel.org, Kees Cook <kees@...nel.org>
Subject: Re: [PATCH 07/14] x86/ibt: Clean up is_endbr()

On Mon, Sep 30, 2024 at 2:33 AM Peter Zijlstra <peterz@...radead.org> wrote:
>
>
> Which then leads to me rewriting the proposed patch as...

...

> +__noendbr bool is_endbr(u32 *val)
> +{
> +       u32 endbr;
> +
> +       __get_kernel_nofault(&endbr, val, u32, Efault);
> +       return __is_endbr(endbr);
> +
> +Efault:
> +       return false;
> +}

That looks much better.

Acked-by: Alexei Starovoitov <ast@...nel.org>