linux-kernel - Re: [PATCH net-next] net: phy: microchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31efa9fa-f4e3-4538-b09b-b1363e419079@lunn.ch>
Date: Mon, 30 Sep 2024 18:44:09 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: arun.ramadoss@...rochip.com, UNGLinuxDriver@...rochip.com,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: microchip_t1: Interrupt support for
 lan887x

> +static int lan887x_config_intr(struct phy_device *phydev)
> +{
> +	int ret;

This driver consistently uses rc, not ret. It would be good to keep
with the existing convention.

    Andrew

---
pw-bot: cr