linux-kernel - Re: [net-next PATCH 04/11] net: ravb: Combine if conditions in RX csum validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc2c91c8-d379-44f6-b7b7-acc9a208cb02@omp.ru>
Date: Mon, 30 Sep 2024 20:40:52 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Paul Barker <paul@...rker.dev>, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
CC: Paul Barker <paul.barker.ct@...renesas.com>, Geert Uytterhoeven
	<geert+renesas@...der.be>, Niklas Söderlund
	<niklas.soderlund+renesas@...natech.se>, Biju Das
	<biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH 04/11] net: ravb: Combine if conditions in RX
 csum validation

On 9/30/24 19:08, Paul Barker wrote:

> From: Paul Barker <paul.barker.ct@...renesas.com>
> 
> We can merge the two if conditions on skb_is_nonlinear(). Since
> skb_frag_size_sub() and skb_trim() do not free memory, it is still safe
> to access the trimmed bytes at the end of the packet after these calls.
> 
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey