linux-kernel - Re: [PATCH] ceph: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP_1jRDmkQBH4BaxicTyYXtTJVjLXQb9T_XCmvUm7qTf0A@mail.gmail.com>
Date: Mon, 30 Sep 2024 20:09:06 +0200
From: Ilya Dryomov <idryomov@...il.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: xiubli@...hat.com, ceph-devel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: Use struct_size() helper

On Thu, Sep 12, 2024 at 5:39 PM Thorsten Blum <thorsten.blum@...lux.com> wrote:
>
> Use struct_size() to calculate the number of bytes to be allocated.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  fs/ceph/addr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index c4744a02db75..ab494f250d80 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -2133,7 +2133,7 @@ static int __ceph_pool_perm_get(struct ceph_inode_info *ci,
>         }
>
>         pool_ns_len = pool_ns ? pool_ns->len : 0;
> -       perm = kmalloc(sizeof(*perm) + pool_ns_len + 1, GFP_NOFS);
> +       perm = kmalloc(struct_size(perm, pool_ns, pool_ns_len + 1), GFP_NOFS);
>         if (!perm) {
>                 err = -ENOMEM;
>                 goto out_unlock;
> --
> 2.46.0
>

Applied.

Thanks,

                Ilya