linux-kernel - Re: [PATCH v2 3/4] KVM: selftests: Allow slot modification stress test with quirk disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0398a8b5-2d7b-4a85-8452-0e2f51a4fde4@sirena.org.uk>
Date: Mon, 30 Sep 2024 19:15:42 +0100
From: Mark Brown <broonie@...nel.org>
To: Yan Zhao <yan.y.zhao@...el.com>
Cc: Aishwarya TCV <aishwarya.tcv@....com>, rick.p.edgecombe@...el.com,
	kai.huang@...el.com, isaku.yamahata@...el.com, dmatlack@...gle.com,
	sagis@...gle.com, erdemaktas@...gle.com, graf@...zon.com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	Paolo Bonzini <pbonzini@...hat.com>, seanjc@...gle.com,
	Naresh Kamboju <naresh.kamboju@...aro.org>,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH v2 3/4] KVM: selftests: Allow slot modification stress
 test with quirk disabled

On Wed, Sep 25, 2024 at 08:42:56AM +0800, Yan Zhao wrote:
> On Tue, Sep 24, 2024 at 01:26:20PM +0100, Aishwarya TCV wrote:
> > On 03/07/2024 03:12, Yan Zhao wrote:

> > > Add a new user option to memslot_modification_stress_test to allow testing
> > > with slot zap quirk KVM_X86_QUIRK_SLOT_ZAP_ALL disabled.

> > > Signed-off-by: Yan Zhao <yan.y.zhao@...el.com>

> > When building kselftest-kvm config against next-20240924 kernel with
> > Arm64 an error "'KVM_X86_QUIRK_SLOT_ZAP_ALL' undeclared" is observed.

> Ah, I forgot to hide  

>   "TEST_REQUIRE(kvm_check_cap(KVM_CAP_DISABLE_QUIRKS2) &
>                        KVM_X86_QUIRK_SLOT_ZAP_ALL)"
> inside "#ifdef __x86_64__" when parsing opts though it's done in run_test().

This bug, which Aishwarya originally reported against -next, is now
present in mainline:

   https://storage.kernelci.org/mainline/master/v6.12-rc1/arm64/defconfig+kselftest/gcc-12/logs/kselftest.log

I couldn't find a fix being posted so I sent:

   https://lore.kernel.org/r/20240930-kvm-build-breakage-v1-1-866fad3cc164@kernel.org 

which also fixes the same issue in memslot_perf_test.c.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)